-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Improve error messages for connection issues in online code editor
#6888
Programming exercises
: Improve error messages for connection issues in online code editor
#6888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
src/main/webapp/app/exercises/programming/shared/code-editor/ace/code-editor-ace.component.ts
Outdated
Show resolved
Hide resolved
...pp/app/exercises/programming/shared/code-editor/container/code-editor-container.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS1, all seems to be working as expected
checked both normal coding exercises and exam mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts4, worked well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline mode and errors are working for me after some delay (see video). TS5, exam mode testing session.
I get errors for all operations except for deletion, where I get no feedback at all:
https://github.com/ls1intum/Artemis/assets/9006596/f36a3a46-c431-418a-903f-efcbfe18eb6c
I would be fine with this being solved in a follow-up though => approve ✅
Note: The deletion errors were visible for @aplr in Firefox, but not for me in Chrome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the issues @pal03377 mentioned, the improvements worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts5 during the exam testing session. I got errors when not connected to wifi for all operations except the deletion of the file on both Safari and Chrome.
Note that rename and adding a file does explicitly state that the internet connection is bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5 during exam mode testing session. Loading and editing existing files works as described.
However, I don't receive any error for deletion while offline as @pal03377 mentioned.
Programming exercises
: Improve error messages for connection issues in code editorProgramming exercises
: Improve error messages for connection issues in online code editor
Checklist
General
Client
Motivation and Context
Students should not be confused when the connection issues to the Artemis server cause the online editor to malfunction. So the error messages should be improved.
Description
Whenever an action is not possible in the code editor due to a connection issue an error is displayed at the top right telling the student about this problem.
Additionally when trying to load a file without an internet connection a blank file is shown instead of the last loaded file as before this PR. This blank file is read only.
Steps for Testing
Prerequisites:
Exam Mode Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Client
Screenshots